Storage

Data last fetched 2026-11-11 19:12 UTC · 79 open PR(s) across 12 repo(s) · a3603c

Back to index | Grouped by repo | Flat view

storage — Direct Review (36 PRs)

xcp-ng/http-nbd-transfer

xcp-ng/http-nbd-transfer: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
This pull request needs your attention.#20 Robustify code	27	Wescoeur	klmp200 review pending rzr approved Storage review pending	47.6moderate	2	reviewers	Partially approved. Last action: AnthoineB requested review from klmp200.

xcp-ng/sm

xcp-ng/sm: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
This pull request needs your attention.#198 fix(cleanup): untag relinking on leaves moved during coalesce	2	Lankou66	Nambrok review pending Wescoeur review pending Storage review pending	6.8fresh	2	reviewers	Waiting for reviewers. Last action: Lankou66 pushed new commits. ⚠ There have been pushes since the last review(s).
#196 fix(linstor): retry volume building on volume manager instantiation	5	Kuruyia	Wescoeur changes requested Storage review pending	15.7fresh	2	author	Wescoeur requested changes. Last action: Wescoeur requested review.
This pull request needs your attention.#179 fix(linstor) AbortGc launched even on local.	41	Ythogtha	Millefeuille42 approved Wescoeur review pending Storage review pending	61.8stale	2	reviewers	Partially approved. Last action: AnthoineB requested review from Wescoeur.
This pull request needs your attention.#192 Fix stale dm nodes	6	AnthoineB	Lankou66 review pending Storage review pending	18.3fresh	2	reviewers	Waiting for reviewers. Last action: AnthoineB requested review from Lankou66.
This pull request needs your attention.#160 SR.scan: mark gone VDIs missing instead of forgetting	69	DatBewar	Wescoeur review pending Storage review pending	73.9stale	15	reviewers	Waiting for reviewers. Last action: DatBewar requested review from Wescoeur.

xcp-ng/xcp-ng-tests

xcp-ng/xcp-ng-tests: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
This pull request needs your attention.#788 storage/linstor: use JSON output for LINSTOR resource listing	1	Kuruyia	rzr approved Storage review pending	3.5fresh	1	reviewers	Partially approved. Last action: rzr approved.
#724 conftest.py: add fail_with_9() fixture	44	semarie	glehmann commented rzr approved ydirson changes requested XAPI & Network review pending Hypervisor & Kernel review pending Storage review pending	32.4moderate	1	author	ydirson requested changes. Last action: ydirson left a review comment.
This pull request needs your attention.#749 Cannot be merged: this pull request has conflicts that must be resolved tests/storage: Test the NBD endpoint exposed by XAPI	29	last-genius	AnthoineB review pending OS Platform & Release review pending Storage review pending	49.9moderate	2	author + reviewers	Waiting for reviewers. Last action: AnthoineB requested review from AnthoineB. ⊘ Conflicts must be resolved before this can merge.
This pull request needs your attention.#759 Cannot be merged: this pull request has conflicts that must be resolved Graceful interrupt via Ctrl+C	22	vxgmichel	glehmann approved XAPI & Network review pending Hypervisor & Kernel review pending Storage review pending	40.3moderate	7	author + reviewers	Partially approved. Last action: vxgmichel pushed new commits. ⊘ Conflicts must be resolved before this can merge. ⚠ There have been pushes since the last review(s).
#313 Cannot be merged: this pull request has conflicts that must be resolved Add host failure test to verify VM resiliency and SR stability	539	rushikeshjadhav	Wescoeur review pending glehmann commented stormi commented ydirson commented Storage review pending	98.7stale	51	author	Reviewer(s) commented. Last action: Wescoeur mentioned Lankou66. ⊘ Conflicts must be resolved before this can merge.

xcp-ng/xcp-ng-xapi-plugins

xcp-ng/xcp-ng-xapi-plugins: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
This pull request needs your attention.#75 lvm.py, service.py: sanitize plugin arguments	16	DatBewar	Lankou66 review pending guzu review pending semarie approved Storage review pending	38.1moderate	2	reviewers	Partially approved. Last action: AnthoineB requested review from Lankou66.

xcp-ng/xcp-storage

xcp-ng/xcp-storage: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
This pull request needs your attention.#19 Add LINSTOR backend	95	Wescoeur	Storage review pending	83.3stale	0	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
#22 Add LINSTOR controller and satellite helpers	34	Wescoeur	Kuruyia commented Storage review pending	58.2moderate	5	author	Reviewer(s) commented. Last action: Kuruyia requested review.
This pull request needs your attention.#46 feat(tests/core): add `FifoLock` tests + more for `FileLock`	5	Wescoeur	Storage review pending	15.7fresh	5	reviewers	Waiting for initial review. Last action: Wescoeur requested review.
This pull request needs your attention.#45 Add more semgrep checks	5	Wescoeur	Storage review pending	15.7fresh	5	reviewers	Waiting for initial review. Last action: Wescoeur requested review.
This pull request needs your attention.#44 fix(tests/core): simplify `LinstorController.get_uri` tests	5	Wescoeur	Storage review pending	15.7fresh	5	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#43 Robustify pytest usage: fixtures instead of @patch, autospec, fake FS...	7	Wescoeur	Storage review pending	20.7fresh	5	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#42 feat(tests/core): add `log` tests	7	Wescoeur	Storage review pending	20.7fresh	7	reviewers	Waiting for initial review. Last action: Wescoeur requested review.
This pull request needs your attention.#41 feat(core): add `ThreadGroup` helper	8	Wescoeur	Storage review pending	23.1fresh	7	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#40 feat(core): add `kill_process` helper	8	Wescoeur	Storage review pending	23.1fresh	7	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#39 feat(core): use a new helper `scoped_factory` to prevent leaks	8	Wescoeur	Storage review pending	23.1fresh	7	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#38 feat(core): simplify code using `Clock`/`Timer` helpers	8	Wescoeur	Storage review pending	23.1fresh	7	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#37 chore(tests): add Python 3.6 test packages for XCP-ng 8.3	12	Wescoeur	Storage review pending	31.3moderate	7	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#36 Robustify semgrep rules	13	Wescoeur	Storage review pending	33.1moderate	7	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#35 Rework GH workflow	13	Wescoeur	Storage review pending	33.1moderate	8	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#34 Add `FifoLock`/`ReadWriteFifoLock` helpers	15	Wescoeur	Storage review pending	36.5moderate	8	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#33 Add `close_fd` helper	18	Wescoeur	Storage review pending	41.1moderate	8	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#32 fix(core): robustify socket helpers + add UNIX support	18	Wescoeur	Storage review pending	41.1moderate	8	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#21 feat(core): add `FileLock`/`ReadWriteFileLock` helpers	37	Wescoeur	Storage review pending	60.5stale	8	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#16 Add SMAPIv3 plugins build process + connectors architecture + tapdisk plugin.py skeleton	117	Wescoeur	Storage review pending	87.2stale	8	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#31 Add more Protocol/RPC tests	21	Wescoeur	Storage review pending	45.1moderate	8	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#30 refactor(core): simplify `iptables` commands	21	Wescoeur	Storage review pending	45.1moderate	8	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#14 Add new semgrep rules + enforce conventions	117	Wescoeur	Storage review pending	87.2stale	8	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#13 Add XAPI SMAPIv3 API stubs	120	Wescoeur	Storage review pending	87.7stale	8	reviewers	Waiting for initial review. Last action: Wescoeur pushed new commits.
This pull request needs your attention.#6 Add TCP client/server modules	139	Wescoeur	Millefeuille42 review pending Storage review pending	89.5stale	8	reviewers	Waiting for reviewers. Last action: Wescoeur pushed new commits. ⚠ There have been pushes since the last review(s).

Team Member Involvement (43 PRs)

xapi-project/blktap

xapi-project/blktap: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
#442 Switch blktap licensing to GPLv2	139	AnthoineB	guzu approved	69.8stale	27	reviewers	⚠ Partially approved, but no other reviewer. Last action: AnthoineB mentioned MarkSymsCtx.

xapi-project/sm

xapi-project/sm: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
#802 Install relative symlinks	138	ydirson	Nambrok approved Wescoeur approved rzr approved	90.0stale	6	approved	All approvals satisfied. Last action: Nambrok approved.
#800 refactor: use VHD header to fetch block size	217	Millefeuille42		95.1stale	216	reviewers	Waiting for initial review. Last action: Millefeuille42 pushed new commits.
#784 Use serial instead of SCSI ID for USB devices	337	Wescoeur	MarkSymsCtx changes requested	97.2stale	294	author	MarkSymsCtx requested changes. Last action: MarkSymsCtx requested changes.

xcp-ng-rpms/coccinelle

xcp-ng-rpms/coccinelle: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
#4 Rebuild to sync with ocaml-4.14.4	6	Kuruyia	Wescoeur approved rzr approved	18.3fresh	6	approved	All approvals satisfied. Last action: Kuruyia left a PR comment.

xcp-ng-rpms/xha

xcp-ng-rpms/xha: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
#8 Update our patches on 25.2.0-2	23	DatBewar	Wescoeur approved glehmann approved rzr approved	25.9fresh	1	approved	All approvals satisfied. Last action: glehmann approved.

xcp-ng/blktap

xcp-ng/blktap: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
#23 tapdisk: ctrl: grow output buffer for large list responses	47	guzu	AnthoineB review pending Nambrok review pending	66.9stale	1	reviewers	Waiting for reviewers. Last action: guzu pushed new commits. ⚠ There have been pushes since the last review(s).
#27 tapdisk: wait for the NBD requests in flight before closing an image	34	guzu	AnthoineB review pending Nambrok review pending	58.2moderate	19	reviewers	Waiting for reviewers. Last action: guzu undrafted the PR.
#29 tapdisk: nbdserver: reuse the data buffer of the requests	34	guzu	AnthoineB review pending Nambrok review pending	58.2moderate	27	reviewers	Waiting for reviewers. Last action: guzu pushed new commits. ⚠ There have been pushes since the last review(s).

xcp-ng/http-nbd-transfer

xcp-ng/http-nbd-transfer: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
#19 Fix and modernize code	28	Wescoeur	klmp200 changes requested rzr commented	52.9moderate	1	author	klmp200 requested changes. Last action: klmp200 requested changes.

xcp-ng/sm

xcp-ng/sm: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
#195 fix(linstor): clear FLAG_TYPE_ABORT in linstor-manager:abortGc	5	Ythogtha	Kuruyia commented Millefeuille42 changes requested Nambrok review pending Wescoeur changes requested	11.0fresh	1	author	Wescoeur requested changes. Last action: Millefeuille42 requested changes.
#108 implement the capability to desactivate CBT on all vdi snapshot child	364	Lankou66	Nambrok review pending Wescoeur approved	97.5stale	2	reviewers	Partially approved. Last action: Lankou66 pushed new commits. ⚠ There have been pushes since the last review(s).
#170 feat(qcow2util): Support Qcow2 subclusters	56	AnthoineB	Kuruyia approved Nambrok review pending Wescoeur approved	51.0moderate	2	reviewers	Partially approved. Last action: Wescoeur approved.
#145 qcow2_helper: add support for compressed images	141	guzu	AnthoineB approved Nambrok review pending	83.4stale	2	reviewers	Partially approved. Last action: guzu pushed new commits. ⚠ There have been pushes since the last review(s).
#168 feat: add LVM metadata backup	57	Kuruyia	Millefeuille42 commented Wescoeur changes requested	51.3moderate	2	author	Wescoeur requested changes. Last action: Wescoeur requested changes.
#132 feat(linstor): implement vdi_revert on linstor	196	klmp200	Millefeuille42 commented Nambrok review pending	94.6stale	2	author	Reviewer(s) commented. Last action: klmp200 pushed new commits. ⚠ There have been pushes since the last review(s).
#128 feat(lvmsr): support `vdi_revert` on lvm	230	klmp200	Lankou66 approved Millefeuille42 approved Nambrok review pending	91.9stale	2	reviewers	Partially approved. Last action: klmp200 pushed new commits. ⚠ There have been pushes since the last review(s).
#124 feat(filesr): support vdi_revert	257	klmp200	AnthoineB review pending Kuruyia review pending Lankou66 approved Millefeuille42 approved Nambrok review pending Wescoeur review pending Ythogtha approved imperosol review pending	73.6stale	2	reviewers	Partially approved. Last action: klmp200 pushed new commits. ⚠ There have been pushes since the last review(s).
#161 fix(linstor): handle volume creation failure in clone rollback	69	Kuruyia	Millefeuille42 commented Wescoeur review pending klmp200 review pending	68.0stale	35	author	Reviewer(s) commented. Last action: Millefeuille42 resolved a review thread.
#127 Add QCOW2 support	236	Nambrok	Millefeuille42 commented Wescoeur changes requested klmp200 changes requested	83.5stale	47	author	Wescoeur requested changes. Last action: Nambrok pushed new commits. ⚠ There have been pushes since the last review(s).
#125 Cannot be merged: this pull request has conflicts that must be resolved Stable COW release	247	Wescoeur	Lankou66 approved Millefeuille42 approved Nambrok review pending	91.9stale	48	author	Nambrok requested changes. Last action: Wescoeur pushed new commits. ⊘ Conflicts must be resolved before this can merge. ⚠ There have been pushes since the last review(s).

xcp-ng/xcp-ng-org

xcp-ng/xcp-ng-org: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
#546 docs: document HA behavior with two hosts	50	DatBewar	AnthoineB review pending Wescoeur approved klmp200 approved stormi review pending thomas-dkmt approved	43.1moderate	7	reviewers	Partially approved. Last action: olivierlambert mentioned stormi.
#553 docs: Add VDI delete a disk information	27	DatBewar	Wescoeur changes requested stormi review pending thomas-dkmt approved	41.0moderate	12	author	Wescoeur requested changes. Last action: Wescoeur requested changes.
#542 docs: add troubleshooting page for ZFS SR not imported after reboot	55	webdawg	Ythogtha approved freezed commented stormi review pending thomas-dkmt changes requested	57.2moderate	21	author	thomas-dkmt requested changes. Last action: webdawg mentioned freezed, stormi.
#520 Cannot be merged: this pull request has conflicts that must be resolved doc: Add pull request guidelines	93	stormi	bleader commented dinhngtu commented freezed commented glehmann commented lmolina commented rzr commented thomas-dkmt changes requested ydirson commented	72.1stale	23	author	thomas-dkmt requested changes. Last action: glehmann left a review comment. ⊘ Conflicts must be resolved before this can merge.
#486 Cannot be merged: this pull request has conflicts that must be resolved Add a glossary plugin with terms	147	freezed	stormi review pending thomas-dkmt changes requested	75.9stale	40	author	thomas-dkmt requested changes. Last action: thomas-dkmt mentioned freezed, thomas-dkmt. ⊘ Conflicts must be resolved before this can merge.
#502 Cannot be merged: this pull request has conflicts that must be resolved Add some details in docs related to NFS SR settings	107	freezed	Kuruyia approved olivierlambert commented stormi review pending thomas-dkmt approved	77.5stale	54	author	Reviewer(s) commented. Last action: thomas-dkmt approved. ⊘ Conflicts must be resolved before this can merge. ⚠ The author has been active since the comment, but has not re-requested a review.

xcp-ng/xcp-ng-tests

xcp-ng/xcp-ng-tests: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
#738 storage: add VBD blktap tests	34	guzu	Nambrok review pending OS Platform & Release review pending	44.9moderate	13	reviewers	Waiting for reviewers. Last action: guzu pushed new commits. ⚠ There have been pushes since the last review(s).
#739 storage: add tapdisk NBD server tests	34	guzu	AnthoineB approved rzr approved	44.9moderate	13	approved	All approvals satisfied. Last action: guzu pushed new commits. ⚠ There have been pushes since the last review(s).
#722 Check that revert feature is enabled on SR when testing vdi_revert	44	klmp200	Kuruyia approved Wescoeur approved Ythogtha review pending glehmann approved	65.2stale	35	reviewers	Partially approved. Last action: Wescoeur approved.
#726 linstor: add test for healthcheck in linstor-manager	44	Nambrok	Kuruyia commented Wescoeur changes requested glehmann approved	65.2stale	43	author	Wescoeur requested changes. Last action: glehmann approved.
#359 Cannot be merged: this pull request has conflicts that must be resolved Replace manual process handling by local_cmd()	390	guzu → glehmann	gthvn1 commented rzr commented stormi review pending ydirson review pending	84.4stale	43	author	Reviewer(s) commented. Last action: gthvn1 left a review comment. ⊘ Conflicts must be resolved before this can merge.
#627 Cannot be merged: this pull request has conflicts that must be resolved [waiting for sm feature] Create tests for vdi_revert on file based SRs	124	klmp200	Lankou66 approved Millefeuille42 approved glehmann approved gthvn1 commented	76.0stale	44	author	Reviewer(s) commented. Last action: klmp200 left a PR comment. ⊘ Conflicts must be resolved before this can merge. ⚠ The author has been active since the comment, but has not re-requested a review.
#625 Add test for rolling pool update with VM availability check on updated host	127	DatBewar	Ythogtha approved glehmann approved stormi changes requested	84.3stale	82	author	stormi requested changes. Last action: stormi requested changes mentioning DatBewar, glehmann.
#362 Cannot be merged: this pull request has conflicts that must be resolved Collect logs in case of test failure	366	guzu → ydirson	dinhngtu changes requested glehmann commented	97.5stale	127	author	ydirson requested changes. Last action: stormi transferred ownership to ydirson. ⊘ Conflicts must be resolved before this can merge.

xcp-ng/xcp-ng-xapi-plugins

xcp-ng/xcp-ng-xapi-plugins: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
#56 Switch to python3	338	ydirson	Wescoeur approved gthvn1 approved rzr approved semarie changes requested	97.2stale	37	author	semarie requested changes. Last action: semarie requested changes.

xcp-ng/xcp-storage

xcp-ng/xcp-storage: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
#27 Add a timeout to `drbdsetup` commands to prevent them from getting stuck	23	Wescoeur	Kuruyia approved Millefeuille42 approved Ythogtha approved	47.6moderate	8	approved	All approvals satisfied. Last action: Wescoeur pushed new commits. ⚠ There have been pushes since the last review(s).
#15 Add XCP storage RPC daemon	117	Wescoeur	DatBewar approved Kuruyia commented	67.3stale	8	author	Reviewer(s) commented. Last action: Wescoeur pushed new commits. ⚠ There have been pushes since the last review(s).
#11 Add DRBD helpers	133	Wescoeur	Kuruyia commented Millefeuille42 commented	74.1stale	8	author	Reviewer(s) commented. Last action: Wescoeur pushed new commits. ⚠ There have been pushes since the last review(s).
#10 Add JSON-RPC client/server modules + API	134	Wescoeur	Kuruyia commented	74.9stale	8	author	Reviewer(s) commented. Last action: Wescoeur pushed new commits. ⚠ There have been pushes since the last review(s).
#24 chore: add GH commit conventions check	34	Wescoeur	Kuruyia commented Ythogtha approved	57.3moderate	21	author	Reviewer(s) commented. Last action: Ythogtha approved.
#17 Cannot be merged: this pull request has conflicts that must be resolved Add DRBD backend function `get_openers`	113	Kuruyia	Millefeuille42 review pending Wescoeur changes requested	85.9stale	23	author	Wescoeur requested changes. Last action: Kuruyia pushed new commits. ⊘ Conflicts must be resolved before this can merge. ⚠ There have been pushes since the last review(s).

xenserver/xha

xenserver/xha: open pull requests
PR	Created	Author	Reviewers	Staleness	Last Activity	Waiting For	Rationale
#33 Fix initialisation of unknown index value which overflows `hbvar.sa_to`	149	DatBewar	edwintorok commented minglumlu approved	71.9stale	26	author	Reviewer(s) commented. Last action: DatBewar pushed new commits. ⚠ There have been pushes since the last review(s).